Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: amanda https://bugzilla.redhat.com/show_bug.cgi?id=225243 ------- Additional Comments From rbrich@xxxxxxxxxx 2008-03-11 12:12 EST ------- Hi. I'm slightly missing what are our roles here, but thanks :-) About your changes: The PIE patch is apparently still needed, as the build fails with your spec: /usr/bin/ld: .libs/alloc.o: relocation R_X86_64_PC32 against `debug_alloc' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: Bad value That means, -PIE option can only be used for executables, not libraries, so adding -fPIE/-pie to common *FLAGS cannot work. And thus the autotools will be still needed. As for the username changing, it's needed when upgrading from older packages and the %post is not for server subpackage, but for main amanda package (or say, common), where the .amandahosts file is contained. Rest seems ok, but I'll rather wait with the updgrade at least for final release of Amanda 2.6.0, they are still doing changes... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review