Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ltspfs - LTSP filesystem https://bugzilla.redhat.com/show_bug.cgi?id=428748 ------- Additional Comments From kevin@xxxxxxxxx 2008-03-10 15:13 EST ------- See below - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. See below - Sources match upstream md5sum: OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. The URL should possibly be: https://code.launchpad.net/ltspfs 2. This is a prerelease snapshot? Release should be: 0.0.20080114%{?dist} instead of 0.20080114%{?dist} See: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-d97a3f40b6dd9d2288206ac9bd8f1bf9b791b22a 3. You should include a comment on how to check out this version: http://fedoraproject.org/wiki/Packaging/SourceURL#head-615f6271efb394ab340a93a6cf030f2d08cf0d49 4. rpmlint says: ltspfs.x86_64: E: zero-length /usr/share/doc/ltspfs-0.4.2/ChangeLog Suggest: Drop the Changelog until it has anything in it? ltspfsd.x86_64: W: non-conffile-in-etc /etc/udev/rules.d/88-ltsp.rules Should this be a conf(noreplace)? Or does it matter? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review