Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: java-1.6.0-openjdk - The OpenJDK 1.6.0 runtime environment https://bugzilla.redhat.com/show_bug.cgi?id=433070 ------- Additional Comments From langel@xxxxxxxxxx 2008-03-07 16:39 EST ------- rpmlint output: $ rpmlint ~/Desktop/java-1.6.0-openjdk-1.6.0.0-0.1.b06.fc9.src.rpm java-1.6.0-openjdk.src: W: patch-not-applied Patch1: java-1.6.0-openjdk-win32.patch java-1.6.0-openjdk.src: W: patch-not-applied Patch2: java-1.6.0-openjdk-jhat.patch Patches are applied, but not using the method expected %patch1. java-1.6.0-openjdk.src: W: strange-permission generate-fedora-zip.sh 0775 Fixed. $ rpmlint /notnfs/fitzsim/rpmbuild/RPMS/i386/java-1.6.0-openjdk-1.6.0.0-0.1.b06.fc8.i386.rpm java-1.6.0-openjdk.i386: E: non-standard-dir-perm /usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0/jre/lib/zi/Australia 02755 ... I don't see this problem. java-1.6.0-openjdk.i386: W: file-not-utf8 /usr/share/doc/java-1.6.0-openjdk-1.6.0.0/THIRD_PARTY_README Fixed java-1.6.0-openjdk.i386: W: incoherent-version-in-changelog 1:1.6.0.0-.1.b06 1:1.6.0.0-0.1.b06.fc8 Fixed java-1.6.0-openjdk.i386: E: useless-explicit-provides jdbc-stdext Fixed java-1.6.0-openjdk.i386: E: file-in-usr-marked-as-conffile /usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0/jre/lib/security/cacerts ... These should probably eventually be replaced by symlinks somewhere into /etc, but we'll need to discuss this with OpenJDK upstream developers. Can you add a FIXME comment in the %files section saying so? Done. java-1.6.0-openjdk-devel.i386: W: file-not-utf8 /usr/share/doc/java-1.6.0-openjdk-devel-1.6.0.0/THIRD_PARTY_README Fixed java-1.6.0-openjdk-devel.i386: E: non-standard-dir-perm /usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0/include 02755 ... Don't see these problems. $ rpmlint /notnfs/fitzsim/rpmbuild/RPMS/i386/java-1.6.0-openjdk-javadoc-1.6.0.0-0.1.b06.fc8.i386.rpm java-1.6.0-openjdk-javadoc.i386: E: non-standard-dir-perm /usr/share/javadoc/java-1.6.0-openjdk/api/java/util/jar 02755 ... Don't see this. MUST - check no duplicate files I'm seeing these warnings: *** WARNING: identical binaries are copied, not linked: /usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0/bin/keytool and /usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0/jre/bin/keytool I added a comment about this. srpm and spec file updated: http://langel.fedorapeople.org/java-1.6.0-openjdk/java-1.6.0-openjdk.spec http://langel.fedorapeople.org/java-1.6.0-openjdk/java-1.6.0-openjdk-1.6.0.0-0.1.b06.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review