Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: boinc-client - A platform for distributed computing Alias: boinc-client-review https://bugzilla.redhat.com/show_bug.cgi?id=433187 ------- Additional Comments From xjakub@xxxxxxxxxx 2008-03-07 04:52 EST ------- >* %pre script >------------------------------------------------------ >[ -x /etc/init.d/boinc-client ] && /sbin/service boinc-client stop >------------------------------------------------------ > - This line is not needed, and actually this is problematic > because with this script boinc-client stops every time > boinc-client is upgraded. Oh yes, this is a relict from previous versions where the service was enabled by default. Removed. >* /sbin/ldconfig >------------------------------------------------------ >%post devel -p /sbin/ldconfig >%postun devel -p /sbin/ldconfig >------------------------------------------------------ > - These are not needed Fixed. >* Macros usage > - Please unify macros usage. For example: >------------------------------------------------------ >mv $RPM_BUILD_ROOT%{_bindir}/ca-bundle.crt \ > $RPM_BUILD_ROOT%{_localstatedir}/lib/boinc >....... ^^^^^^^^^^^^^^^^^ >/sbin/restorecon /var/lib/boinc/error.log > ^^^^^^^ >------------------------------------------------------ Fixed, hope in all (3?) occurrences. >* Directory ownership issue > - %_localstatedir/lib/boinc is not owned by any package. Fixed. >* Dependency for -devel subpackage > - Please check the dependency for -devel package. > For example, %_includedir/BOINC/crypt.h contains: >------------------------------------------------------ > 28 #if !(defined(USE_OPENSSL) || defined(USE_RSAEURO)) > 29 #define USE_OPENSSL 1 > 30 //#define USE_RSAEURO 1 > 31 #endif > 43 #ifdef USE_OPENSSL > 44 #include <openssl/rsa.h> >------------------------------------------------------ > This means -devel subpackage should have: > "Requires: openssl-devel" (here I am not mentioning about > BuildRequires). I see, I went through the headers using a (foolish) script: cd /usr/share/BOINC for HEADER in `grep "#include" * | sed -e '/\".*\.h\"/d' -e 's/^.*<\([^.]*\).*>.*/\/usr\/include\/\1\.h/g'`; do rpm -qf $HEADER; done And it seems that this was the only missing Requires. Just hope I didn't miss anything. Thanks for all remarks! New SPEC file and SRPM: http://www.fi.muni.cz/~xjakub/boinc/boinc-client-5.10.40-7.20080206svn.fc8.src.rpm http://www.fi.muni.cz/~xjakub/boinc/boinc-client.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review