Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ggobi - Open source visualization for exploring high-dimensional data https://bugzilla.redhat.com/show_bug.cgi?id=436340 ------- Additional Comments From lkundrak@xxxxxxxxxx 2008-03-06 12:19 EST ------- 1.) Please fix your desktop file: ggobi.desktop: error: value "Application;Astronomy;Science;Education" for string list key "Categories" in group "Desktop Entry" does not have a semicolon (';') as trailing character ggobi.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated Note that it's always a good idea to use desktop-file-validate. It's your friend! 2.) %description devel GGobi headers This is not very accurate. It also contains pkg-config file and symlink to library. I would also say this is not very accurate: Group: Applications/System Maybe Development/Libraries? 3.) %files ... %{_sysconfdir}/xdg/ggobi/ggobi You should probably own %{_sysconfdir}/xdg/ggobi By the way, isn't it a %config file? Or maybe user-editable %config(noreplace)? Builds in mock now; will continue review once built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review