Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: synfig - Synfig is a vector based 2D animation package https://bugzilla.redhat.com/show_bug.cgi?id=428568 ------- Additional Comments From marc@xxxxxxxxxxxxxx 2008-03-06 09:02 EST ------- (In reply to comment #7) > 1* URL: please rip off /Main_Page from the url in the case they change the name, > http://synfig.org/ should be enough. > Done > 2* BuildRequires - it is usually better to use one line by requirement, so the > BR would be versioned and changes can be seen easily via our cvs. But I leave > this up to you. Done > > 3* Remove: Requires: pkgconfig, ImageMagick Done > > 4* %description : Remove the added space from the beginning of the line: > high dynamic range images, and a flexible plugin system. Done > > 5* %package devel > - BuildRequires is a wrong item from a -devel package, you should only use > Requires: > - pkgconfig is already provided by ETL-devel, no need to add it twice > - synfig.pc has Requires: OpenEXR ETL libxml++-2.6 sigc++-2.0 > you have to add all theses requires using the package name form. > - Requires: synfig and %{name} = %{version}-%{release} are the same > requirement, please remove synfig and use %{name} = %{version}-%{release} > (versionned requires), instead. Done > > 6* Prevent timestramps changes for installed headers. Use: > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" Done > > 7* Again, please remove theses lines: (unneeded) > %post devel -p /sbin/ldconfig > %postun devel -p /sbin/ldconfig Done > > 8* %doc README doc/ - Theses doc are installed twice (in main and -devel) > if the documentation is big, you may need to split into a separate package. > It also depend if this is development related doc or user doc. development and shifted there > > 9* Do we really need this file ? ltdl should take care of the available module > %config(noreplace) %{_sysconfdir}/synfig_modules.cfg > can you see where the file (and it's path) is written within the source code ? > At least I don't expect this file is aimed for user edition, so you may need to > only use %config in this case. Needed and left as is with the theory that if someone has modified it I should not overwrite it. It will cause less breakage this way I think in the long run. > > 10* %{_bindir}/synfig-config same tweak is required from the ETL-config > you will need to keep the timestramps from a reference file using something like > touch -r README $RPM_BUILD_ROOT%{_bindir}/synfig-config (same for ETL-config ) > Done > 11* mod_imagemagick, mod_magickpp, mod_mng and mod_gradient seems not to have > been built. (mod_libavcodec is expected). you need to figure out why. > > vImage ---------------------------> no > ImageMagick ----------------------> no > Magick++ -------------------------> no > ... > Using OpenEXR's "half" type ------> no > > Look at the config.log to see missing BR or wrong directory search paths for > library detection. vImage = propietary, ImageMagick and Magick++ yes OpenEXR half slows down synfig upstream has requested we leave it as is. http://mwiriadi.fedorapeople.org/packages/synfig/synfig.spec http://mwiriadi.fedorapeople.org/packages/synfig/synfig-0.61.08-3.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review