Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnuradio - Software defined radio framework Alias: gnuradio-review https://bugzilla.redhat.com/show_bug.cgi?id=433642 ------- Additional Comments From lkundrak@xxxxxxxxxx 2008-03-04 16:32 EST ------- Wow, this is much better. 1.) I can not believe this worked: :) # $ tar -cf gnuradio-3.1.1-templates.tar gnuradio-core/src/lib/gengen/*.t && gzip gnuradio-3.1.1-templates.tar ... tar -xvvf %{SOURCE1} mv *.t gnuradio-core/src/lib/gengen/ However, you could shorten the comment with -czf :) And the proper way to unpack is to use %setup macro --- it can do that! Also why do you move those *.t files? Doesn't tar preserve paths while unpacking? And you don't uncompress the archive -- did that work? And why do you pass two -v-s? 2.) PATH=/usr/libexec/sdcc:$PATH %{_libexecdir} here? 3.) in %files: Please replace the doc/ directory location with %{docdir} in %{_datadir}/doc/usrp* The package is brewing in my mock now, I'll proceed once it builds. PS: Your gcc43 patch is awesome; I never seen that lon gcc43 patch yet :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review