Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dayplanner - An easy and clean Day Planner https://bugzilla.redhat.com/show_bug.cgi?id=433488 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #296522|0 |1 is obsolete| | ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-03-04 06:42 EST ------- Created an attachment (id=296726) --> (https://bugzilla.redhat.com/attachment.cgi?id=296726&action=view) holiday_japan again. > : Last modified: May 3, 2008 > : by Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> > Is date correct? Of course not correct... Well, * Replace /usr with %{_prefix} (prefix=/usr) * For perl modules dependency, don't write rpm names directly but write the module names the rpms provide, such as "BuildRequires: perl(Locale::gettext)" ! By the way, devel-tools/GenDesktop needs perl(Locale:gettext), but this script doesn't seem to be called and actually your srpm builds without BuildRequires: perl-gettext: http://koji.fedoraproject.org/koji/taskinfo?taskID=490198 Other things are okay. ---------------------------------------------------------------- This package (dayplanner) is APPROVED by me ---------------------------------------------------------------- P.S. > P.S If you have time could you also review this: > https://bugzilla.redhat.com/show_bug.cgi?id=434614? Thanks in advance! Well, for the last few days I was checking review requests to which I had not replied for a few days and actually it seems I have commented on about 20 review requests within these 5 days... So if you want me to review the above, would you wait a bit, please? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review