Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: zlib https://bugzilla.redhat.com/show_bug.cgi?id=226671 ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-03-03 00:57 EST ------- I think this package is quite clean now. Really the only thing that bothers me is the what was bothering Patrice earlier: the autool-ization of the original non-autotools-using source. According to cvs annotate, this was done in February, 2007 by Atam Tkac: * Tue Feb 20 2007 Adam Tkac <atkac redhat com> - 1.2.3-7 - building is now automatized - specfile cleanup However, there's nothing that explains why this is needed or what advantage there is to building it this way versus the way the package normally builds. I know this review is dragging on, but is it possible to at least get a couple of lines of comment in the specfile that explain why we need to do this, what bugs it solves, or what problems it avoids? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review