Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grib_api - ECMWF encoding/decoding GRIB software https://bugzilla.redhat.com/show_bug.cgi?id=427121 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-03-02 16:17 EST ------- This all looks good to me. I guess the bad test could be troublesome but if you don't have a problem with then I won't worry about it. I guess if you're not going to need the commented-out scriptlets you could remove them so the spec looks cleaner, but that's really minor. Which name did you think was too generic? I guess "typesizes.mod" might be, but I don't know how many .mod files we're going to end up seeing. Everything else seemed to me to be prefixed, in a subdirectory or simply named such that conflicts would be improbable. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review