Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kmid - A midi/karaoke player for KDE 4 https://bugzilla.redhat.com/show_bug.cgi?id=432607 ------- Additional Comments From kevin@xxxxxxxxxxxxxxxx 2008-03-02 11:25 EST ------- MUST Items: + rpmlint output: as quoted by submitter, all harmless ! not entirely named and versioned according to the Package Naming Guidelines: Release should be 0.2.%{svn_date}svn%{?dist} instead of 0.2. %{svn_date}%{?dist} + spec file name matches base package name + Packaging Guidelines: + License GPLv2+ OK, matches actual license + No known patent problems + No emulator, no firmware, no binary-only or prebuilt components + Complies with the FHS + proper changelog, tags, BuildRoot, Requires, BuildRequires, Summary, Description + no non-UTF-8 characters + relevant documentation included + RPM_OPT_FLAGS are used (%{cmake_kde4} macro) + debuginfo package is valid + no static libraries nor .la files + no duplicated system libraries + no rpaths on i386 and x86_64 + no configuration files, so %config guideline doesn't apply + no init scripts, so init script guideline doesn't apply + GUI executable has .desktop file + .desktop file installed according to the guidelines (uses desktop-file-install) + no timestamp-clobbering file commands + _smp_mflags used + scriptlets are valid + not a web application, so web application guideline doesn't apply + no conflicts + complies with all the legal guidelines + license included as %doc + complies with all the legal guidelines * skipping "source matches upstream" test because this is a SVN checkout + builds on at least one arch (F9 all arches Koji scratch build) + no non-working arches, so no ExcludeArch needed + all build dependencies listed in CMakeLists.txt as well as cmake itself are listed in BuildRequires + translations packaged according to the guidelines (%find_lang) + ldconfig correctly called in %post and %postun + package not relocatable + ownership correct (owns package-specific directories, doesn't own directories owned by another package) + no duplicate files in %files ! permissions: -devel package missing %defattr(-,root,root,-) + %clean section present and correct + macros used where possible ! non-code content: examples (examples/*.kar) have suspicious copyright status * DiesIrae.kar: Mozart, sequencing "(c) 1996 V. Palleschi", may or may not be OK, depending on whether V. Palleschi allowed this * Guantanamera.kar: Joseíto Fernández (1908-1979), almost certainly a copyright violation * MariaDeLasMercedes.kar: Concha Piquer (1908-1990), almost certainly a copyright violation * OFortuna.kar: from the Carmina Burana, music by Carl Orff (1895-1982), almost certainly a copyright violation IMHO we should probably remove the examples entirely (even from the tarball). + no large documentation files, so no -doc package needed + %doc files not required at runtime + all header files in -devel + no static libraries, so no -static package needed + no .pc files, so no Requires: pkgconfig needed + devel symlinks correctly in -devel + /usr/lib/kde4/*.so plugins (NOT symlinks) are correctly NOT in -devel + -devel Requires: %{name} = %{version}-%{release} + no .la files + GUI executable has .desktop file + buildroot is deleted at the beginning of %install + all filenames are valid UTF-8 SHOULD Items: + license included as %doc + no translations for description and summary provided by upstream + package builds in mock (Koji scratch build) + package builds on all architectures (Koji scratch build) + basic functionality tested on F8, works fine + scriptlets are sane + no subpackages other than -devel, so "Usually, subpackages other than devel should require the base package using a fully versioned dependency." is irrelevant + no .pc files, so "placement of .pc files" is irrelevant + no file dependencies MUST FIX: * add "svn" to the Release tag (after the date) * add missing %defattr(-,root,root,-) in %files devel * remove examples (suspicious copyright status) Fix these and I'll approve this. One thing I'm not sure is how much sense it makes to provide kmid-devel, I don't think anything other than kmid itself actually uses the kmid libs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review