Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lbrickbuster2 - Brickbuster arcade game https://bugzilla.redhat.com/show_bug.cgi?id=435514 ------- Additional Comments From konrad@xxxxxxxxxx 2008-03-02 08:43 EST ------- + for good, - for bad, ? for questionable MUST Items: ? rpmlint: lbrickbuster2.x86_64: E: non-standard-executable-perm /usr/bin/lbrickbuster2 02551 lbrickbuster2.x86_64: E: non-standard-executable-perm /usr/bin/lbrickbuster2 02551 + package named according to naming guidelines + spec file name matches base package name + packaging guidelines + license (GPLv2+) + license matches source files (I just checked game.c, assumed the rest are the same) + COPYING included in RPM + spec is in en_US + spec is quite legible + sources match upstream + compiles/builds on x86_64 + build dependencies listed in BR (tested on koji) + locales handled properly + if shared libraries, must call ldconfig (don't have any) + no Prefix: /usr + don't hostile takeover other packages' directories + no duplicate %files ? proper permissions on files (see rpmlint output above) + %clean section - consistent use of macros (you mix $VARIABLES and %{variables}) + package contains code and permissible content + no need for -doc + %doc doesn't affect runtime + no header files + no static libraries + no pkgconfig + no library files with suffixes + no devel package + no .la libtool archives + %{name}.desktop installed + package doesn't attempt to own other packages' files + %install cleans up build root + filenames are valid UTF8 SHOULD Items: + source includes license texts from upstream ? descriptions/summary don't contain non-English translations, but I doubt they are available + package builds in mock (http://koji.fedoraproject.org/koji/taskinfo?taskID=484020) + package compiles into binary RPMs on all archs (see above) + package functions as described (it's fun :)) + no file dependencies Clean up the macros and assure me that the permissions are OK and I'll set fedora-review to +. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review