Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocsinventory-agent - Open Computer and Software Inventory Next Generation client https://bugzilla.redhat.com/show_bug.cgi?id=435593 ------- Additional Comments From pertusus@xxxxxxx 2008-03-02 05:34 EST ------- Missing BR perl(Digest::MD5) and perl(File::Temp). You should not use fedora in the README file names, but instead something that can be in any derived package, so something like distribution (and in my opinion it is better to avoid writing Fedora as much as possible because of potential trademark issues). Obsoletes: ocsinventory-client <= 1.01 is right, but Provides: ocsinventory-client = %{version}-%{release} is wrong since version is 0.0.8.2, so it provides a version older than the obsoleted version. I am not completly sure what to do in that case. I see 2 possibilities * have Provides: ocsinventory-client = 1.02 # use the following line when version is strictly above 1.01 # ocsinventory-client = %{version}-%{release} * no uncommented Provides but the following comment: # as soon as version is strictly above 1.01 uncomment the following line # ocsinventory-client = %{version}-%{release} The cvs -z3 co command should use a date or a tag such that the same code is checked out in the future. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review