Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocrad -- An Optical Character Recognition program https://bugzilla.redhat.com/show_bug.cgi?id=435433 ------- Additional Comments From panemade@xxxxxxxxx 2008-03-01 09:08 EST ------- (In reply to comment #3) > (In reply to comment #1) > > 3) make install should be called as > > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" > > I found nothing like this in the guidelines. I might have overlooked it of > course. Could you point me at the reasoning for this please? > Yes. thats not mentioned in packaging guidelines but use of INSTALL="install -p" ensures that timestamps will be kept same as upstream released of installed files. You can relate this to http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d175c4aec8c12868dffb5ab Also, build failed with error: Installed (but unpackaged) file(s) found: /usr/share/info/dir -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review