Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocaml-cairo - OCaml library for accessing cairo graphics https://bugzilla.redhat.com/show_bug.cgi?id=434713 ------- Additional Comments From panemade@xxxxxxxxx 2008-03-01 08:58 EST ------- Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=481958 + rpmlint is silent for SRPM and for RPM. + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. + Package ocaml-cairo-1.2.0.cvs20080224-2.fc9 => Provides: dllmlcairo.so dllmlcairo_lablgtk.so ocaml(Cairo) = 1120d1d2aa838fb82c89723e40027d3e ocaml(Cairo_bigarray) = f5278f29e0f267216517b39938447e1f ocaml(Cairo_ft) = c7b86ae255e7715a56b6730cd62fb0a5 ocaml(Cairo_lablgtk) = 82e26006bc0f771f240d32cee4e40a99 ocaml(Cairo_pdf) = 4e73fe9bce1bcaa3d496352353001779 ocaml(Cairo_png) = 2a83dcbeee368b33e7553e447746d3a7 ocaml(Cairo_ps) = af8d18227472072b7a4cabd1ad743a0d ocaml(Cairo_svg) = e90fc8093ba12fa82a62907377ca4223 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libcairo.so.2 libfreetype.so.6 ocaml(Bigarray) = e881a834bafaaa24bc612d94119cc0f5 ocaml(Buffer) = f6cef633ea14963b84b79c4095c63dc3 ocaml(Callback) = e5ca1fb5990fac2b7b17cbb1712cffe2 ocaml(Complex) = bb333e8e4cda78107ccf27048ca40492 ocaml(Gaux) = 1f8c3af1ec44d0b19146161a687dd947 ocaml(Gdk) = 4cac9e9df9320b71cd77db9bff9f1b91 ocaml(GdkPixbuf) = a5ff570e45ecdc9c9213f393f8d57f2b ocaml(Glib) = 39c579079161658673ebd1ea3a5d3ab9 ocaml(Gobject) = c0ecf32dba4d98abfabf69278beb91f5 ocaml(Gpointer) = 72eda5d9f0d59b5972aa22fcecf67daa ocaml(Int32) = 711321870c949bd3bbdd092d9bae92e4 ocaml(List) = da1ce9168f0408ff26158af757456948 ocaml(Obj) = 5cfae708052c692ea39d23ed930fd64d ocaml(Pango) = b5403be8d9b1c0fb2807ac3675dd0323 ocaml(Pervasives) = 8ba3d1faa24d659525c9025f41fd0c57 ocaml(Printf) = 5dbbf45a03b54e6dbfcf39178d0d6341 ocaml(String) = 2c162ab314b2f0a2cfd22d471b2e21ab ocaml(Sys) = 0da495f5a80f31899139359805318f28 ocaml(Unix) = 9a46a8db115947409e54686ada118599 ocaml(runtime) = 3.10.1 + Package ocaml-cairo-devel-1.2.0.cvs20080224-2.fc9 => Requires: ocaml-cairo = 1.2.0.cvs20080224-2.fc9 + Followed ocaml packaging guidelines. how can I verify source? Add instructions on how to checkout source code in SPEC. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review