Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: perl-Dir-Which - Search for directory entries in a list of directories https://bugzilla.redhat.com/show_bug.cgi?id=376531 ------- Additional Comments From rjones@xxxxxxxxxx 2008-02-28 15:07 EST ------- + rpmlint output rpmlint is clean + package name satisfies the packaging naming guidelines + specfile name matches the package base name - package should satisfy packaging guidelines should filter provides/requires (http://fedoraproject.org/wiki/Packaging/Perl) + license meets guidelines and is acceptable to Fedora + license matches the actual package license + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm md5 a5af1ec69180f9b54e9b07cf4cb8bada + package successfully builds on at least one architecture i386 + ExcludeArch bugs filed N/A + BuildRequires list all build dependencies + %find_lang instead of %{_datadir}/locale/* N/A + binary RPM with shared library files must call ldconfig in %post and %postun N/A + does not use Prefix: /usr + package owns all directories it creates + no duplicate files in %files + %defattr line + %clean contains rm -rf $RPM_BUILD_ROOT + consistent use of macros + package must contain code or permissible content + large documentation files should go in -doc subpackage N/A docs are small + files marked %doc should not affect package + header files should be in -devel N/A + static libraries should be in -static N/A + packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' N/A + libfoo.so must go in -devel N/A + -devel must require the fully versioned base N/A + packages should not contain libtool .la files N/A + packages containing GUI apps must include %{name}.desktop file N/A + packages must not own files or directories owned by other packages N/A + %install must start with rm -rf %{buildroot} etc. + filenames must be valid UTF-8 Optional: + if there is no license file, packager should query upstream + translations of description and summary for non-English languages, if available ? reviewer should build the package in mock ? the package should build into binary RPMs on all supported architectures + review should test the package functions as described scriptlets should be sane + pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin -------- Please take a look at the Perl packaging guidelines. I'm not sure about this requirement for filtering provides & requires and as such I've just raised a question on fedora-packaging: https://www.redhat.com/archives/fedora-packaging/2008-February/msg00111.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review