Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: blueproximity - A tool that locks/unlocks your screen when your bluetooth devices gets away/near from your computer https://bugzilla.redhat.com/show_bug.cgi?id=432905 ------- Additional Comments From sereinity@xxxxxxxxx 2008-02-25 15:49 EST ------- It still builds under mock, run, and rpmlint runs ok One issue must be fixed : you have a duplicate of blueproximity_base.svg (use a symlink) Many lines can be remove : install -d %{buildroot} install -d %{buildroot}%{_bindir} install -d %{buildroot}%{_datadir}/pixmaps/ install -d %{buildroot}%{_datadir}/locale/ install -d %{buildroot}%{_datadir}/locale/$i install -d %{buildroot}%{_datadir}/locale/$i/LC_MESSAGES/ mkdir -p %{buildroot}%{_datadir}/applications %dir %{_datadir}/%{name}/ ( and modify next line to %{_datadir}/%{name} ) MUST Items: + MUST: rpmlint must be run on every package : Ok + MUST: The package must be named according to the Package Naming Guidelines. + MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption on Package Naming Guidelines. + MUST: The package must meet the Packaging Guidelines. + MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. + MUST: The License field in the package spec file must match the actual license. + MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. + MUST: The spec file must be written in American English. + MUST: The spec file for the package MUST be legible. If the reviewer is unable to read the spec file, it will be impossible to perform a review. Fedora is not the place for entries into the Obfuscated Code Contest (http://www.ioccc.org/). + MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. + MUST: The package must successfully compile and build into binary rpms on at least one supported architecture. + MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. + MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines; inclusion of those as BuildRequires is optional. Apply common sense. + MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. + MUST: Every binary RPM package which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. + MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. + MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. Refer to the Guidelines for examples. - MUST: A package must not contain any duplicate files in the %files listing. + MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. + MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines. + MUST: The package must contain code, or permissable content. This is described in detail in the code vs. content section of Packaging Guidelines. + MUST: Large documentation files should go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity) + MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. + MUST: Header files must be in a -devel package. + MUST: Static libraries must be in a -static package. + MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). + MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. + MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} + MUST: Packages must NOT contain any .la libtool archives, these should be removed in the spec. + MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. + MUST: Packages must not own files or directories already owned by other packages. + MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} + MUST: All filenames in rpm packages must be valid UTF-8. SHOULD Items: + SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. + SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. + SHOULD: The reviewer should test that the package builds in mock. See MockTricks for details on how to do this. (i686 and x86_64) ~ SHOULD: The package should compile and build into binary rpms on all supported architectures. (not tested on ppc and pcc64) + SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. + SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. + SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. + SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. + SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. Please see File Dependencies in the Guidelines for further information. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review