[Bug 426302] Review Request: openuniverse - OpenGL space simulator focused on the Solar System

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openuniverse - OpenGL space simulator focused on the Solar System


https://bugzilla.redhat.com/show_bug.cgi?id=426302





------- Additional Comments From sergio.pasra@xxxxxxxxx  2008-02-24 17:22 EST -------
+ source files match upstream
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible.
+ latest version is being packaged.
+ BuildRequires are proper.
+ %clean is present.
+ package installs properly
+ debuginfo package looks complete.
+ rpmlint is silent.
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
- no duplicates in %files.
warning: File listed twice: /usr/share/openuniverse/docs
warning: File listed twice: /usr/share/openuniverse/docs/BUGS.TXT
warning: File listed twice: /usr/share/openuniverse/docs/OGL_sm.gif
warning: File listed twice: /usr/share/openuniverse/docs/cyclo.gif
warning: File listed twice: /usr/share/openuniverse/docs/linux.gif
warning: File listed twice: /usr/share/openuniverse/docs/manual.html
warning: File listed twice: /usr/share/openuniverse/docs/shot2.gif
warning: File listed twice: /usr/share/openuniverse/docs/shot3.gif
warning: File listed twice: /usr/share/openuniverse/docs/title.gif
+ file permissions are appropriate.
+ scriptlets are ok.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ GUI app. 
It includes a desktop file and it's properly installed (but the icon it's
missing, is that intended?)

So, please fix the duplicated entries in files and the package it's approved

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]