Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: autogen - Automated text file generator https://bugzilla.redhat.com/show_bug.cgi?id=432542 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-02-24 13:12 EST ------- I have not checked this yet, however I just write some comments (In reply to comment #12) > > ? BR: chrpath > > - Well, would you try to remove rpath by not using chrpath? > > ("Removing Rpath" of > > http://fedoraproject.org/wiki/Packaging/Guidelines ) > > Using chrpath should be considered as a last resort.. > > + there is no --disable-rpath option in configure > + using sed to modify libtool as shown in Wiki causes build failure > > Is it worth trying to modify the code/Makefiles as mentioned in the Wiki? I did > not try it because they say it is "not always easy or sane to do". - Actually ------------------------------------------------------------------ make %{__smp_mflags} LIBTOOL=%{_bindir}/libtool ------------------------------------------------------------------ removed rpath as expected (please check the result of http://koji.fedoraproject.org/koji/taskinfo?taskID=466340 http://koji.fedoraproject.org/koji/taskinfo?taskID=466331 ) > > > * License tag > > (See License-check.log) > > - Actually as %{_includedir}/autoopts/options.h (and so on) > > is LGPLv3+, "BSD or" part must be deleted. > > Changed dual licensing of autogen-libopts-devel by dropping BSD. - Also the license of autogen-libopts should be changed to just LGPLv3+ as the libraries in -libopts uses the header files in issue. > > ! multilib conflict > > - autoopts/autoopts-config.in contains > > ------------------------------------------------------------- > > 20 libdir="@libdir@" > > ------------------------------------------------------------- > > or so, which differs between on 32bit arch and on 64bit arch. > > So this causes multilib conflict. Please try to resolve this > > conflict. > > http://fedoraproject.org/wiki/PackagingDrafts/MultilibTricks > > Ok. However, some pkgconfig files (eg., cairo.pc) have: > [...] > libdir=/usr/lib64 > [...] > Libs: -L${libdir} -lcairo > [...] > > Since the above write-up is a draft, I just want to confirm from you. - pkgconfig files are no problems because they uses different directories between 32 bits <-> 64 bits (%{_libdir}/pkgconfig, not /usr/lib/pkgconfig). On the other hand it must be checked that 64 bits pkgconfig file does not use /usr/lib but uses /usr/lib64 correctly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review