Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: minbar - Athan call and prayer times notification software https://bugzilla.redhat.com/show_bug.cgi?id=431188 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-02-24 09:44 EST ------- For 0.2.1-4: * sed usage ------------------------------------------------------- cat %{name}.desktop.in |sed "s|Utility;Utility;|Utility;|" > %{name}.desktop.tmp mv %{name}.desktop.tmp %{name}.desktop.in ------------------------------------------------------- - You can use -i (in place) option. ------------------------------------------------------- sed -i -e "s|\(Utility;\)\1|\1|" %{name}.desktop.in ------------------------------------------------------- * macros - As I said in the previous comments, please replace all /usr/bin with %{_bindir}. ------------------------------------------------------- if [ -x /usr/bin/gtk-update-icon-cache ]; then /usr/bin/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor fi ------------------------------------------------------- * scriptlet - As I said in the previous comments the scriptlets for GTK+ icon cache are not yet right. Please refer to the section "GTK+ icon cache" of http://fedoraproject.org/wiki/Packaging/ScriptletSnippets again. * Documents - Files under %_mandir are automatically marked as %doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review