Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xf86-video-nouveau - X.org nouveau driver https://bugzilla.redhat.com/show_bug.cgi?id=433738 ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-02-21 17:10 EST ------- Builds OK; rpmlint says: xorg-x11-drv-nouveau.src: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 3) which I don't really care about, fix it if you like. xorg-x11-drv-nouveau.x86_64: W: incoherent-version-in-changelog 2.1.5-2 1:0.0.10-1.fc9 You probably just want to start afresh with your changelog, but if not you should at least have an entry for the current revision. Could you provide instructions for generating the tarball in use? Just a coupe of comments for checking out a specific git tag from the repository should be fine; see http://fedoraproject.org/wiki/Packaging/SourceURL for more info. Is this actually version 0.0.10 or is it a snapshot from the source tree made after 0.0.10 was released? If the latter, we have specific guidelines relating to the versioning of snapshots, which would indicate that this should be 0.0.10-1.20080221 or 0.0.10-1.20080221git (what follows the date is up to you; some use an abbreviated commit ID). Have to run now; more review later. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review