Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: liblqr-1 - LiquidRescale library https://bugzilla.redhat.com/show_bug.cgi?id=429202 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-02-21 12:23 EST ------- For 0.1.0-3: * Description - The %description of -devel package is wrong. -------------------------------------------------------------- %description devel The libqr-devel package contains the static libraries and header files ^^^^^^^^^^^^^^^^ -------------------------------------------------------------- * .so symlink location (In reply to comment #7) > * symlink for linkage > - %{_libdir}/libXXXX.so should be in -devel package > (%{_libdir}/libXXXX.so.X symlink should be in main package). > This type of errors can be detected by using rpmlint > commands (in rpmlint package). > ------------------------------------------------------------- > [tasaka1@localhost liblqr-1]$ rpmlint *0.1.0-2*rpm > liblqr-1.i386: W: devel-file-in-non-devel-package /usr/lib/liblqr-1.so > ....... > ------------------------------------------------------------- - Please check your rpms by rpmlint to detect generic packaging errors. For newest rpm: --------------------------------------------------------------- liblqr-1-devel.i386: E: library-without-ldconfig-postin /usr/lib/liblqr-1.so.0.0.0 liblqr-1-devel.i386: E: library-without-ldconfig-postun /usr/lib/liblqr-1.so.0.0.0 --------------------------------------------------------------- What I said was: - %_libdir/liblqr-1.so.0.0.0 and %_libdir/liblqr-1.so.0 must be in main package - %_libdir/liblqr-1.so must be moved to -devel package. * BuildRequires - Well, I rechecked BuildRequires and actually glib2-devel is sufficient for BuildRequires (gimp-devel is not needed for BuildRequires) * Typo - Please fix below (by the way with this typo rebuild actually fails....) --------------------------------------------------------------- find %buildroot -name \*.la -exec %rm -f {} \; ^^^^ --------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review