Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: liblqr-1 - LiquidRescale library https://bugzilla.redhat.com/show_bug.cgi?id=429202 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-02-20 12:47 EST ------- For general packaging guidelines you can refer to: http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines For 0.1.0-2: * spec file name - must coincide with the name of main package, i.e. spec file must have the name "liblqr-1.spec". * Group tag - Usually the library related rpm has "Group: System Environment/Libraries" and its -devel subpackage usually has "Group: Development/Libraries". * Requires/BuildRequires - "BuildRequires: glib" is not needed. GIMP uses glib2, liblqr-1 also uses glib2 not glib (GLib 1). Also liblqr-1 has "BuildRequies: gimp-devel", which also pulls glib2 automatically. - "Requires: pkgconfig" must be removed from main package. The main package is not for development and pkgconfig must not be needed. - Also "Requires: gimp" is not needed for main package. This library does not need gimp itself, only gimp-libs is needed and such dependency are automatically treated by rpmbuild. - -devel subpackage does not need "Requires: gimp-devel". From installed pkgconfig .pc file and header files, only "glib2-devel" (and also pkgconfig) is needed as Requires for -devel subpackage - Also -devel subpackage must have "Requires: %{name} = %{version}-%{release}" * License - For this package there is no reason that -devel subpackage should have different License tag. * macros usage consistency - If you want to use %__rm , please also use %__make %__install for consistency. * symlink for linkage - %{_libdir}/libXXXX.so should be in -devel package (%{_libdir}/libXXXX.so.X symlink should be in main package). This type of errors can be detected by using rpmlint commands (in rpmlint package). ------------------------------------------------------------- [tasaka1@localhost liblqr-1]$ rpmlint *0.1.0-2*rpm liblqr-1.i386: W: devel-file-in-non-devel-package /usr/lib/liblqr-1.so ....... ------------------------------------------------------------- * Directory ownership issue - Please make it sure that all directories which are created when installing a rpm are owned by the rpm. For this package the directory %{_includedir}/lqr-1/, %{_includedir}/lpr must be owned by -devel subpackage. ! By the way, when you write: ------------------------------------------------------------- %files devel %{_includedir}/lqr-1/ ------------------------------------------------------------- This contains the directory %{_includedir}/lqr-1 and all files/directories/etc under %{_includedir}/lqr-1. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review