Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: guake - Drop-down terminal for GNOME https://bugzilla.redhat.com/show_bug.cgi?id=433477 guidolinfrancesco@xxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |guidolinfrancesco@xxxxxxxx ------- Additional Comments From guidolinfrancesco@xxxxxxxx 2008-02-19 14:59 EST ------- Hi, this is an unofficial review. There are some things that need to be fixed: [-] You should use %{dist} in the release tag: Release: 1%{dist} [-] You should use %{?_smp_mflags} in the make command: make %{?_smp_mflags} this enable parallel build on multicore CPU. [-] Use %{_sysconfdir} instead of /etc: %{_sysconfdir}/gconf/schemas/guake.schemas -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review