Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lpsolve - OpenOffice.org 3.0 dependency Linear Programming (MILP) solver https://bugzilla.redhat.com/show_bug.cgi?id=433292 ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-02-19 12:22 EST ------- Looks good to me; the properl compiler flags are used and the debuginfo . I've no clue how to test this, but I can run the included binary and get help output so it at least does something. One thing I noticed while looking closer at the source tree: There are some files in bfp/bfl_LUSOL/LUSOL which look to be documentation, and one license statement which I guess should be packaged. It looks like a separate project has been inforporated. Judging from the documentation there, it seems that it is intended for it to have a separate release at some point but I couldn't find one. There are also some txt files there which mean nothing to me, and two which have the same content for some reason. So LUSOL_LGPL.txt needs to be packaged, and LUSOL-overview.txt and LUSOL_README.txt should probably be packaged as well. Just let me know if you agree and I'll approve this; there's no need for you to post a new package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review