Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lpsolve - OpenOffice.org 3.0 dependency Linear Programming (MILP) solver https://bugzilla.redhat.com/show_bug.cgi?id=433292 ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-02-19 00:18 EST ------- This builds cleanly and elicits only this from rpmlint: lpsolve-devel.x86_64: W: no-documentation which is OK. Did you find somewhere any information on which versions of the LGPL are permitted? I couldn't find anything besides LGPL (and the standard GPL notice in the bison output, which doesn't matter). I believe that LGPLv2+ is acceptable in this situation, but it would be good to clarify this with the upstream developers if possible. The compiler is called with just "-O3" when it should be called with the full set of %{optflags}. This has the result of the debuginfo package being broken. It looks like the ccc script will need to be patched to set "opts" to something other than "-O3". Actually the whole build thing is a bit weird. Does the Makefile that's there not work? (It looks like it would still need patching anyway.) * source files match upstream: 842d6c0fb72c8912c8747f096d07c01c1ecab137b8e5b90e41f94ddf2e5cd543 lp_solve_5.5.0.11_source.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. ? license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. X compiler flags are not the required set. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly X debuginfo package is not complete. * rpmlint has acceptable complaints. * final provides and requires are sane: lpsolve-5.5.0.11-1.fc9.x86_64.rpm liblpsolve55.so()(64bit) lpsolve = 5.5.0.11-1.fc9 = /sbin/ldconfig lpsolve-devel-5.5.0.11-1.fc9.x86_64.rpm lpsolve-devel = 5.5.0.11-1.fc9 = lpsolve = 5.5.0.11-1.fc9 * a shared library is installed; ldconfig is called properly. There are no versioned .so files, so the unversioned one is properly in the main package. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (ldconfig) * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * headers are in the -devel package. * no pkgconfig files. * no static libraries. * no libtool .la files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review