Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cwdaemon - Morse daemon for the parallel or serial port https://bugzilla.redhat.com/show_bug.cgi?id=433161 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-02-18 00:02 EST ------- (In reply to comment #1) > ln -sv %{docdir}/%{name}-%{version}/README %{_datadir}/%{name}/README > > should create the link. Then include it in the file list. Well, current spec file --------------------------------------------------------------------- #don't include this twice rm -rf $RPM_BUILD_ROOT%{_datadir}/%{name}/README #Lets make a simlink instead ln -sv %{docdir}/%{name}-%{version}/README %{_datadir}/%{name}/README ............................ %files %doc AUTHORS ChangeLog COPYING README TODO ............................ %{_datadir}/%{name}/README --------------------------------------------------------------------- is wrong because of the following reason. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines - MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. In other words, a package should work properly with "rpm -ivh --excludedocs". For this package when "--excludedocs" is used - %{docdir}/%{name}-%{version}/README is not installed - But the symlink %{_datadir}/%{name}/README is created this causes this symlink broken, which must be avoided. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review