[Bug 429221] Review Request: dzcomm - Dzcomm a RS-232 API/lib

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dzcomm - Dzcomm a RS-232 API/lib


https://bugzilla.redhat.com/show_bug.cgi?id=429221





------- Additional Comments From iphands@xxxxxxxxx  2008-02-17 14:54 EST -------
(In reply to comment #8)
> Still not
> * Actually this does not build.
>   http://koji.fedoraproject.org/koji/taskinfo?taskID=422215
> * Fedora specific compilation flags are yet not honored.
>   Please recheck the section "Compiler flags" of
>   http://fedoraproject.org/wiki/Packaging/Guidelines
>   You can check what flags are used for Fedora now by
>   `rpm --eval %optflags`.
> * The installation directory is perhaps wrong.
> --------------------------------------------------------------------
> Installing lib/unix/libdzcom.a to /var/tmp/dz0.9.9i-2.fc9-root-mockbuild/lib
> --------------------------------------------------------------------
>   Shared libraries must be installed into %_libdir or /%_lib (in
>   some special cases). On 64 bits this is /usr/lib64, not /usr/lib.
>   Perhaps you want to use %configure macro
> 
> (In reply to comment #4)
> > > * BuildRoot does not match Fedora guidelines.
> > The package has its own root dir in the zipfile... (I don't know the procedure
> > with this)
>   What do you mean by this?

Okay the CFLAGS should be honored now.
I changed the BuildRoot to match what is suggested in the guidelines.
I can not figure out why the %configure macro doesn't work. When I enable it the
build fails right after (or during?) the find-debuginfo.sh... It seems the
script is looking for the directory "/var/tmp/$RPM_BUILD_ROOT" which is not there.

Any hints?

Thanks,
-Ian

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]