Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pcmanfm - Extremly fast and lightweight file manager https://bugzilla.redhat.com/show_bug.cgi?id=433182 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |j.w.r.degoede@xxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From j.w.r.degoede@xxxxxx 2008-02-17 14:21 EST ------- I've done a full review, result below. <humor> Unfortunately I cannot approve this package as every package should have atleast one patch. Luckily I found a 64 bit bug, causing the package to fail to work (crash) on 64 bit. So I've written a patch fixing this so that we can meet the every package should have atleast one patch rule. </humor> MUST FIX -------- * Apply the to be attached patch fixing crashing on 64 bit. The patch may look strange for a 64 bit patch, but it really fixes a 64 bit issue: -The header in question contains guards to protect it from multiple inclusion -These guards where copy pasted from another header without changing the define checked and set, therefor this header things its already included while its not -This causes various prototypes to not be declared, and the compiler to assume their return type is int (aka 32 bits) -However some return a pointer, which should be 64 bit and now gets truncated to 32 bits. -Boom (aka crash) Should Fix ---------- * Send the 64 bit patch upstream * Ask upstream to use freedesktop.org icon installation location instead of obsolete /usr/share/pixmaps Although there is a MUST FIX, I trust you to include the patch so I'm going to set the approved flag, please include the patch before building the first time. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review