Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: anyRemote - Bluetooth remote control (+GUI for it) https://bugzilla.redhat.com/show_bug.cgi?id=433135 ------- Additional Comments From anyremote@xxxxxxx 2008-02-17 13:39 EST ------- OK. Corrected *spec and *src.rpm are here: Spec URL: http://downloads.sourceforge.net/anyremote/anyremote-fedora.spec?use_mirror=osdnSRPM URL: http://downloads.sourceforge.net/anyremote/anyremote-4.3-2.fc8.src.rpm?use_mirror=osdn 2 Guidolin Francesco: I agree with comments (and already corrected tham) except: > Don't use %define for name and version Are You serious ? Using of %{name} is clearly specified at http://fedoraproject.org/wiki/Packaging/Guidelines > Add libdir to configure script: i do not think it is necessary, since i've run configure with --prefix=... and this is implies --libdir=... > Don't require coreutils, binutils, bash, gawk, bc, uucp In general this is true. But not in this case, because RPM will _not_ find them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review