Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: blueproximity - A tool that locks/unlocks your screen when your bluetooth devices gets away/near from your computer https://bugzilla.redhat.com/show_bug.cgi?id=432905 ------- Additional Comments From sereinity@xxxxxxxxx 2008-02-17 12:56 EST ------- In the .desktop the field Icon should be "Icon=blueproximity_base" In %file section please use : %{_datadir}/applications/fedora-%{name} Source0: http://downloads.sourceforge.net/blueproximity/%{name}-%{version}.tar.gz Is more easier to use wen the package will be update pygtk2-libglade require pygtk2 which require pygobject2 so keep over pygobject2 and pygtk2 Please fix all rpmlint error and fixable warning : - E: description-line-too-long blueproximity.src: E: invalid-spec-name blueproximity-1.spec blueproximity.src:69: W: macro-in-%changelog setup blueproximity.src:73: W: macro-in-%changelog version blueproximity.src:76: W: macro-in-%changelog name (to fix that use %%setup, %%{name} ... into the changelog) blueproximity.src: W: no-%build-section (add an empty %build section) blueproximity.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 5) And please update the date into the changelog (unless you can curve time) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review