Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: crystalspace - Crystal Space a free 3D engine https://bugzilla.redhat.com/show_bug.cgi?id=432033 ------- Additional Comments From j.w.r.degoede@xxxxxx 2008-02-17 11:55 EST ------- (In reply to comment #9) > For 1.2-3: > > * As I wrote some missing dependency for -devel subpackage as "Example", > it seems that there are some more missing dependencies for -devel package > - cegui-devel > - zlib-devel > (I guess adding more 2 BR listed above should be enough) > Sorry, I missunderstood. I did a full check and couldn't find any other headers besides the 2 above which I've added > * It seems that adding INSTALL="install -p" to make install actually works > http://koji.fedoraproject.org/koji/taskinfo?taskID=426911 > Strange as the makefile is justb a skeleton calling jam, but if it works thats good! Added. > ! This weekend I will try to check license issues (if any) for this > package (more than 10000 files needs checking) Okay, about your analysis, I agree, except that the movierecorder plugin really is GPLv2 and not GPLv2+, as it includes (and uses) the nuppelvideo.h file which says: /* This file is from the NuppelVideo project: * * (c) Roman Hochleitner roman@xxxxxxxxxxxxxxxxx * NuppelVideo is distributed under the GNU GENERAL PUBLIC LICENSE version 2 */ This makes the list: main : GPLv2+ and GPLv2 -utils: GPLv2+ and GPLv2 -demos: GPLv2+ -devel: GPLv2+ -doc: ???? So to make things easier, esp the ????, I've just added a License tag of: "GPLv2+ and GPLv2" to the main package, and let all the subpackages inherent this. I've added a large comment above the main License tag explaining why it is what it is. Also I will contact upstream about this, as I believe they intend the core of crystalspace to be LGPL not GPL. Here is a new (hopefully the last) version: Spec URL: http://people.atrpms.net/~hdegoede/crystalspace.spec SRPM URL: http://people.atrpms.net/~hdegoede/crystalspace-1.2-4.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review