Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-tidy - Python wrapper for tidy, from the HTML tidy project https://bugzilla.redhat.com/show_bug.cgi?id=433110 ondrejj@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ondrejj@xxxxxxxxxx Summary|Review Request: python-tidy |Review Request: python-tidy |- Python wrapper for tidy, |- Python wrapper for tidy, |from the HTML tidy project |from the HTML tidy project ------- Additional Comments From ondrejj@xxxxxxxxxx 2008-02-17 02:44 EST ------- BLOCKER: There is a mix of licenses for source package. You chosen wrong license for this package. Please, be careful when setting package license tags. BLOCKER: Package does not match package-naming-guidelines. Your package is named python-tidy and upstream package uTidylib. I see, that you are using just one part from this source, but I don't know, if we can mix that this way. BLOCKER: python-tidy.noarch: E: explicit-lib-dependency libtidy Add version info for libtidy requirement. Other comments: I think a better group for this package is Development/Languages . Add version for python-devel. uTidylib requires python>=2.3 This code is not required: %{python_sitelib}/tidy %if 0%{?fedora} >= 9 %{python_sitelib}/%{oname}-%{version}-py%{pyver}.egg-info You can use %{python_sitelib}/* As I don't know, what to do with this license mix, I can't approve you package now. If you can give me a link to more information. You can ask author to remove path.py from this package and rename it's package as you need. Otherwise you need to fix these problems. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review