Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: anyRemote - Bluetooth remote control (+GUI for it) https://bugzilla.redhat.com/show_bug.cgi?id=433135 ------- Additional Comments From guidolinfrancesco@xxxxxxxx 2008-02-16 16:35 EST ------- Hi, this is an informal review, I can't approve your package or sponsor you. [-] Don't use %define for name and version [-] Summary should'n end with a dot [-] Group Applications/Telephony doesn't exist, use one of the groups in cat /usr/share/doc/rpm*/GROUPS [-] Source tag should contain a link to the original tarball: Source0: http://downloads.sourceforge.net/anyremote/anyremote-4.3.tar.gz [-] Recommended Buildroot is %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) [-] Don't require coreutils, binutils, bash, gawk, bc, uucp, bluez-utils, bluez-libs, libXtst. RPM will find them itself. [-] Add libdir to configure script: ./configure --libdir=%{_libdir} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review