Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocaml-cryptokit - OCaml library of cryptographic and hash functions https://bugzilla.redhat.com/show_bug.cgi?id=432482 ------- Additional Comments From rjones@xxxxxxxxxx 2008-02-15 12:53 EST ------- Thanks for the review. I have changed the license as suggested and I have "unduplicated" the README %doc file, so now only the LICENSE file is duplicated in both packages. Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-cryptokit.spec SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-cryptokit-1.3-2.fc8.src.rpm This is the diff to the specfile from before: diff -u -r1.1 ocaml-cryptokit.spec --- ocaml-cryptokit.spec 12 Feb 2008 11:35:13 -0000 1.1 +++ ocaml-cryptokit.spec 15 Feb 2008 17:50:35 -0000 @@ -3,11 +3,11 @@ Name: ocaml-cryptokit Version: 1.3 -Release: 1%{?dist} +Release: 2%{?dist} Summary: OCaml library of cryptographic and hash functions Group: Development/Libraries -License: LGPLv2 +License: LGPLv2 with exceptions URL: http://pauillac.inria.fr/~xleroy/software.html Source0: http://caml.inria.fr/distrib/bazar-ocaml/cryptokit-1.3.tar.gz BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) @@ -99,7 +99,7 @@ %files devel %defattr(-,root,root,-) -%doc README LICENSE Changes doc +%doc LICENSE Changes doc %if %opt %{_libdir}/ocaml/*.a %{_libdir}/ocaml/*.cmxa @@ -109,5 +109,9 @@ %changelog +* Fri Feb 15 2008 Richard W.M. Jones <rjones@xxxxxxxxxx> - 1.3-2 +- Don't duplicate the README file in both packages. +- Change the license to LGPLv2 with exceptions. + * Tue Feb 12 2008 Richard W.M. Jones <rjones@xxxxxxxxxx> - 1.3-1 - Initial RPM release. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review