Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO https://bugzilla.redhat.com/show_bug.cgi?id=432259 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-02-15 11:20 EST ------- Well, for 0.6.5-1: * bconf - Your usage of bconf conditional treatment is not right. Please to the following link for example. http://cvs.fedora.redhat.com/viewcvs/*checkout*/rpms/gimp/devel/gimp.spec * BuildRequires - It seems dotconf is not in Fedora yet. If you want to use dotconf, you have to submit another review request for dotconf. * Directory ownership issue - Please make it sure that all directories which are created when installing a rpm are owned by some package. For example, the directory %{_sysconfdir}/peech-dispatcher itself is not owned by any packages. * libtool .la files - must be removed. * EVR (Epoch-Version-Release) specific dependency - The dependency between subpackages must be EVR (not only Version) specific. * /sbin/ldconfig - (Usually, and actually for this package) calling /sbin/ldconfig is not needed for -devel package. * Static archive - Packaging static archive is forbidden when providing shared libraries, please remove them. Also please check if configure accepts --disable-static option. * Info file - Files under %_infodir are automatically marked as %doc. * Changelog - Please check http://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs - Especially using %date macro in your way is forbidden. In this way %date changes every time you rebuild this srpm, which changes the old changelog entry - One %changelog must be written in one spec file. i.e. writting %changelog for every subpackage is not allowed. These %changelog's must be unified. (In reply to comment #5) > Also how will I distribute the init scripts since they are not part of the > original package? As a patch? - You can add it as other sources like %SOURCE1. ? symlink which seems modules - BTW does this package work well if symlink .so under %_libdir/speech-dispatcher are not in main package? These type of files are usually dlopen'ed and not aimed for being used from other packages (i.e. not aimed for being in -devel package). %defattr - We now recommend %defattr(-,root,root,-) * %post/%postun dependency for /sbin/install-info - is missing for -doc-en, -doc-cs (please check the section "Texinfo" of http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ) ? By the way do you really want to create -doc-en, -doc-cs subpackages for only info files? ! Please change release number of your spec every time you modify your spec file to avoid confusion. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review