Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openvpn-auth-ldap - OpenVPN plugin for LDAP authentication https://bugzilla.redhat.com/show_bug.cgi?id=245919 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kevin@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From kevin@xxxxxxxxx 2008-02-14 22:54 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (BSD) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 03dedc57efc8d4fc2ffe2c014121299d auth-ldap-2.0.3.tar.gz 03dedc57efc8d4fc2ffe2c014121299d auth-ldap-2.0.3.tar.gz.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. rpmlint says: openvpn-auth-ldap.x86_64: E: non-readable /etc/openvpn/auth/ldap.conf 0600 I assume the conf file is not readable due to containing the LDAP bind info? openvpn-auth-ldap.x86_64: W: no-soname /usr/lib64/openvpn/plugin/lib/openvpn-auth-ldap.so This is not a dynamic library, but a dlopened plugin, so ignore this. Everything looks good here... this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review