Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: figtoipe - FIG to IPE conversion tool https://bugzilla.redhat.com/show_bug.cgi?id=432808 orion@xxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |orion@xxxxxxxxxxxxx Status|NEW |ASSIGNED ------- Additional Comments From orion@xxxxxxxxxxxxx 2008-02-14 18:28 EST ------- Well, the BR needs to be zlib-devel, not zlib. Also, I'd like to see a copy of the license in the final package. * source files match upstream: ea0d1ff62c7c342450fdb0676a2b6192 figtoipe-20071004.tar.gz ea0d1ff62c7c342450fdb0676a2b6192 figtoipe-20071004.tar.gz.new * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * license field matches the actual license. * license is open source-compatible. XXX License text not included in package. * latest version is being packaged. X BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock ( ). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review