Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: VDrift - VDrift is a cross-platform, open source driving/drift racing simulation https://bugzilla.redhat.com/show_bug.cgi?id=234490 ------- Additional Comments From j.w.r.degoede@xxxxxx 2008-02-14 17:10 EST ------- Created an attachment (id=294952) --> (https://bugzilla.redhat.com/attachment.cgi?id=294952&action=view) PATCH: fixing vdrift compile with gcc-4.3 Full review done .. MUST FIX -------- - Doesn't compile with gcc-4.3, patch fixing this attached - It isn't necessary to pass --libdir=%{_libdir} to %configure - %doc docs/* is no good, this will include the following unwanted files: INSTALL HOW_TO_COMPILE.txt SConscript - remove -32x32 from icon name - remove obsolte Version and Encoding entries from .desktop file - Contains some non free files in the sourcetarbal, these must be removed and then we (Fedora) must ship our own sourcetarbal without these, all troublesome files are under the bullet-2.64, so I'm omitting that from their path: glew32.dll: non free SGI licensed version of glew GLUT32.DLL: glut is not free software (unlike freeglut) Glut <directory> contains more non free glew and glut stuff Extras <direcytory>: atleast the COLLADA_DOM is a problem as that contains files under the SCEA Shared Source License 1.0, which seems fine, but hasn't been audited yet, so its easier to just remove these files Demos <direcytory>: atleast the BulletDinoDemo is not properly licensed, I stopped auditing this dir after that, just blow it away You will also need to remove the following 2 lines from Jamfile.in (again in bullet-2.64), to make jam no longer look for the removed dirs: SubInclude TOP Extras ; SubInclude TOP Demos ; -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review