Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fio - multi-threaded IO generator tool https://bugzilla.redhat.com/show_bug.cgi?id=432646 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From panemade@xxxxxxxxx 2008-02-13 20:52 EST ------- 1)Can you add some lines in comments on "Creation of tarball from git"? 2) License is GPLv2+ 3)Use install command as make install prefix=%{_prefix} mandir=%{_mandir} DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ==> this will take care of usage of macros and timestamp of man page. 4) explicit writing of attr for man page is not needed. make it simple as %{_mandir}/man1/* -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review