Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: desktop-data-model - Engine for communicating with Online Desktop Data Model https://bugzilla.redhat.com/show_bug.cgi?id=430939 ------- Additional Comments From otaylor@xxxxxxxxxx 2008-02-13 12:08 EST ------- rpmlint output was empty. What I found going through the package review guidelines and reading the spec file: * UPSTREAM: license needs to be fixed to LGPL (at least for libddm) * UPSTREAM: should have a real tagged and released to gnome.org tarball before this goes into rawhide. * Group: Applications/Internet. Not an application. Maybe 'System Environment/Libraries'? * Summary: and %description need improvement Suggestion: Summary: Engine providing live updates of online data to the desktop %description desktop-data-model provides an engine and client library that allow desktop applications to retrieve data from the online.gnome.org server and elsewhere and get updates when the data changes. This allows creating applications that provide a live display of information from the Internet. * The Requires on GConf for the scriptlets aren't needed. * The handling of the 'version' file isn't ideal ... the version file is used to do an auto-restart of the desktop-data-engine when a new version is installed on the system, so shouldn't be changed until after all the other files are installed. In mugshot.spec we have: %post [...] echo %{version} > %{_datadir}/mugshot/version %files %ghost %{_datadir}/mugshot/version * the -devel package should Requires: pkgconfig for directory ownership. * The Requires on dbus-devel for the -devel subpackage isn't needed. * The devel package shjould require the main package Requires: %{name} = %{version}-%{release} * The %postun should be changed to '%postun -p /sbin/ldconfig' to avoid an unnecessary shell invocation (the %post would take the same change, but the version change above will add a second line to it.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review