Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: usbutils https://bugzilla.redhat.com/show_bug.cgi?id=226518 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jmoskovc@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |NEEDINFO Flag| |fedora-review?, | |needinfo?(jmoskovc@xxxxxxxxx | |m) ------- Additional Comments From panemade@xxxxxxxxx 2008-02-12 07:10 EST ------- 1)rpmlint on current rawhide package gave me usbutils.src: E: non-utf8-spec-file /tmp/usbutils-0.73-1.src.rpm.10603/usbutils.spec ==> use iconv command to convert spec file to UTF8 format iconv -f ISO-8859-1 -t UTF-8 usbutils.spec >usbutils.spec.new mv usbutils.spec.new usbutils.spec usbutils.src: W: summary-ended-with-dot Linux USB utilities. ==> remove dot from summary usbutils.src: E: tag-not-utf8 %changelog usbutils.src: W: invalid-license GPL ==> use GPLv2+ 2) You can add dist tag if you want http://fedoraproject.org/wiki/Packaging/DistTag 3)you can use parallel make as make %{?_smp_mflags} 4)Remove generic INSTALL from %doc 5) Do not use %makeinstall -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review