https://bugzilla.redhat.com/show_bug.cgi?id=2338412 --- Comment #39 from Simone Caronni <negativo17@xxxxxxxxx> --- Spec URL: https://slaanesh.fedorapeople.org/review/SDL3_image.spec SRPM URL: https://slaanesh.fedorapeople.org/review/SDL3_image-3.2.4-1.fc42.src.rpm - Updated to 3.2.4 (requires SDL3 >= 3.2.4 for building). - Convert build requirements that are available in cmake(lib) format to it. - Updated license, added license breakdown. (In reply to Dominik 'Rathann' Mierzejewski from comment #38) > One more small nitpick: > > BuildRequires: libavif-devel > BuildRequires: libjpeg-devel > BuildRequires: libjxl-devel > BuildRequires: libpng-devel > BuildRequires: libtiff-devel > BuildRequires: libwebp-devel > BuildRequires: SDL3-devel > > It'd be advisable to convert the above to cmake() equivalents. > They're being detected with cmake's find_package() calls. > Not a blocker, though. Done for all the packages which are provding cmake(lib). Not all of them unfortunately. > Otherwise, the package looks good. Please correct the license field, > add the licensing break-down and I'll approve. > > Note: per > https://docs.fedoraproject.org/en-US/legal/license-field/#_basic_rule > only the license tags for the code actually compiled into the binary RPM > should > be included, so I'm omitting e.g. the MIT-Khronos-old, libtiff, and others > found > in Xcode/ and VisualC/. Thank you very much for the license work, much appreciated. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2338412 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202338412%23c39 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
