Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO https://bugzilla.redhat.com/show_bug.cgi?id=432259 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo? | ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-02-10 13:33 EST ------- Just leave as ASSIGNED. Potential reviewers can find that currently no one is reviewing this by checking assignee. By the way: Would you check some general guidelines on: http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines And it is useful that you install rpmdevtools rpm and execute "$ rpmdev-newspec speech-dispatcher" to create a skeleton spec file. Also you can check your srpm or rebuilt binary rpms by $ rpmlint XXX.rpm to detect some generic issues on your rpms. >From a quick glance: * Summary must not be ended with dot (you can detect this by using rpmlint. rpmlint is in rpmlint rpm) * Please consider to use %{?dist} tag. http://fedoraproject.org/wiki/Packaging/DistTag * "GPL" license tag is no longer valid for Fedora. http://fedoraproject.org/wiki/Packaging/LicensingGuidelines * Packager tag must not be used. Fedora uses its own tag. * Also Vendor tag must be removed * AutoReqProv: yes is not needed * Please specify BuildRoot (i.e. please don't comment it out) * %setup must be quiet * Please consider to use %configure macro * Support parallel make if possible (please refer to the section "Parallel make" of http://fedoraproject.org/wiki/Packaging/Guidelines * BuildRoot must be cleaned up when %install begins. (see the section "Prepping BuildRoot For %install" of the same wiki) * Changing the mode of files must not be done on scriptlets * Please use macros. You should not use /etc/rc.d but should use /etc/rc.d/init.d and the corresponding macro is %{_sysconfdir} * scriptlets must be quiet unless some errors occur. * We now recommend %defattr(-,root,root,-) * configuration file must be put under %{_sysconfdir}, not under %{_prefix}/%{_sysconfdir}. Please check configure option. I guess %configure does what you want (check what %configure does by rpm --eval %configure) * python directory is not right. It must be %_libdir/python2.5/site-packages, but you must not write this directory in a explicit form but must use some macros. Please refer to: http://fedoraproject.org/wiki/Packaging/Python * Files under %infodir are automatically marked as %doc * Please make it sure that all directories which are created when installing this package are owned by this package or the subpackages of this package. For example, currently the directory %{_libdir}/speech-dispatcher-modules/ itself is not owned by any package * Please create -devel subpackage and move all development-related files to the subpackage. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review