https://bugzilla.redhat.com/show_bug.cgi?id=2350442 --- Comment #13 from Jeremy Cline <jeremy@xxxxxxxxxx> --- (In reply to Nicolas Chauvet (kwizart) from comment #10) > Spec URL: https://dl.kwizart.net/review/DirectX-Headers.spec > SRPM URL: > https://dl.kwizart.net/review/DirectX-Headers-1.615.0-5.fc41.src.rpm > Description: Official Direct3D 12 headers > > Changelog: > - Add comment about debug been disabled > - Comment-out ExclusiveArch and update comment This introduces a warning because of the macro (which, in this case, probably doesn't expand into anything world-breaking, but who knows what the future holds). I'd personally drop the note entirely, but dropping or otherwise mangling the macro so that it doesn't expand is okay too. > - Drop lower-case virtual provides > > Thanks for the review. > > > About testing with d3d12 enabled in WSL2, it's worth to use glmark2-wayland > (and alikes for Xwayland and/or es2 support). > I've managed to test it on Intel Cometlake (gen9) with W11 (23/10 or > something). It seems to faster than llvmpipe (not tried vaapi yet, but I > don't think it's supported on my HW). Thanks, I plan to look at this a bit harder once the driver is built in Mesa. Other than the one rpmlint issue this looks good to me, thanks! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2350442 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202350442%23c13 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
