https://bugzilla.redhat.com/show_bug.cgi?id=2352566 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? CC| |decathorpe@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Taking this review. Package looks mostly good, just two minor issues: 1. > # prevent executables from being installed > %global cargo_install_bin 0 This is a noop. You're already patching out the only [[bin]] target with the Cargo.toml patch, so I would recommend to drop those two lines. 2. The file src/serdes/serde.py has a GPLv2 license header, which doesn't match the MIT license of the crate. It looks like it is only used for testing compatibility with the Python implementation, so I would recommend to %exclude it from the "-devel" package, i.e. add this line below "%{crate_instdir}/": %exclude %{crate_instdir}/src/serdes/serde.py -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2352566 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202352566%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
