https://bugzilla.redhat.com/show_bug.cgi?id=2351347 --- Comment #7 from Akira TAGOH <tagoh@xxxxxxxxxx> --- just a few comments: * According to our Packaging guidelines for fonts at https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/#_assembling_same_family_font_packages:~:text=This%20core%20package%20MUST%20be%20named%20as%20if%20it%20contained%20the%20whole%20font%20family.: This core package MUST be named as if it contained the whole font family. So you must have two sub-packages, adwaita-sans-fonts for AdwaitaSans-*.ttf and adwaita-mono-fonts for AdwaitaMono-*.ttf. * Also https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/#_fontconfig:~:text=Font%20packages%20SHOULD%20include%20the%20fontconfig%20files%2C%20that%20define%20the%20selection%20and%20substitution%20rules%20applying%20to%20their%20font%20files%2C Font packages SHOULD include the fontconfig files, that define the selection and substitution rules applying to their font files, There are some template config file in fonts-rpm-templates package. See /usr/share/fontconfig/templates/basic-font-template.conf for example. * Missing %changelog in prior to %autochangelog. See https://fedora-infra.github.io/rpmautospec-docs/opting-in.html#using-the-autochangelog-macro -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2351347 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202351347%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
