[Bug 2334903] Review Request: ghostty - Terminal emulator in Zig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2334903



--- Comment #43 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---
(In reply to Anthony Oon from comment #36)
> iTerm2-Color-Schemes, this is a general repo for terminal emulators to store
> their theme files (content in terminal-specific formats). Ghostty only
> copies its own files to its data directory. I guess we could patch or PR to
> minimise the dependency to just the ghostty files.
> 

Great. Even better if this can be upstreamed for other distros to take
advantage of.

> Header-only or C libs I think are simple to package:
> utfcpp
> wuffs
> 

Good.  Header files are provided as source.  We like to use Fedora build flags.

> glslang, the current Fedora glslang package only provides glslang.a static
> archives, these are compiled against the gcc C++ stdlib libstdc++ while Zig
> prefers linking against libc++ (clang) with its builtin exe.linkLibCpp()
> step. We could ask the glslang package maintainer about whether a shared-lib
> could be provided.

Fedora prefers gcc unless for technical reasons it cannot be used.

> 
> SPIRV-Cross, fedora seems to package a newer version (15.2.0) compared to
> ghostty on 14.x.x, could look into upgrading versions in ghostty.
> 
> cimgui, this is the generated C lib version of Dear ImGui (C++) they are
> designed to be header+source files you can include in your project I think.
> Notably there's two branches in development docking and non-docking. 
> 
> sentry, breakpad. Ghostty doesn't enable sentry and its breakpad dependency
> by default. I've stubbed this from the package.
> 
> highway, ghostty seems to use this as a vendored dependency adding
> additional compatibility files and headers to convert #defines into zig
> functions. It doesn't seem easy to dynamic link for now.
> 
> libev, ghostty uses libxev. An event loop library for io_uring, epoll,
> kqueue written in Zig.

libxev webpage indicates it has very few dependencies:
https://github.com/mitchellh/libxev
Would be good to package separately. Happy to do this.

> 
> wayland-protocols, plasma-wayland-protocols, these are used for their
> datadirs the devel package provides a pkgconfig we could use under system
> integration as 'pkg-config --variable=pkgdatadir wayland-protocols' for the
> protocol.xml files instead of the bundled files. Think this can be PR'd.

Would be great if this can be done - it is extra work to check which versions
of
wayland-protocols and plasma-wayland-protocols are compatible, but it would
greatly
aid redistribution and adoption of the software.

> 
> The next version will also system integrate with gtk4-layer-shell already.
> wayland, the commit depended on is quite recent and but it's the same being
> needed for protocol xml files which is unchanged.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2334903

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202334903%23c43

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux