https://bugzilla.redhat.com/show_bug.cgi?id=2350109 --- Comment #5 from Pramod V U <pramodvu1502@xxxxxxxxx> --- (In reply to Michael Schwendt from comment #4) > > Release: 1 > > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_version_and_release > --> > https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ > #_release_tag I have added `Release: %{autorelease}` as per the 2nd link. > > Group: System Environment/Base > > BuildRoot: %{_tmppath}/%{name}-%{version}-build > > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections > > Yes, there are still packages that haven't removed the "Group" tag, but > typically if the guidelines say "SHOULD NOT" that is a strong recommendation > not to override it without a compelling reason. If you need a custom > buildroot, define it for your local build environment. Done. Removed the 2 lines > > make > > There's few source files to compile, but as it's a review ticket, notice the > section about "make": > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make > > $ rpm -E %make_build > /usr/bin/make -O -j3 V=1 VERBOSE=1 I have just replaced `make` with `%make_build` without any further modifications. > > /usr/libexec/systemd-cron/mail_for_job > > /usr/libexec/systemd-cron/boot_delay > > /usr/libexec/systemd-cron/remove_stale_stamps > > /usr/libexec/systemd-cron/crontab_setgid > > /usr/libexec/systemd-cron directory is "unowned" currently: > https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ Added in `%files` `%dir /usr/libexec/systemd-cron`. Additionally, I re-enabled support for `/etc/cron.boot` anyways, despite fedora apparently not supporting it with prior cron implementations. I have also updated the reference copy in the original post here on bugzilla. Thanks for the guidance. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2350109 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202350109%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
