https://bugzilla.redhat.com/show_bug.cgi?id=2350109 --- Comment #4 from Michael Schwendt <bugs.michael@xxxxxxx> --- Remaining items from the brief look at the spec file as part of the %license stuff: > Release: 1 https://docs.fedoraproject.org/en-US/packaging-guidelines/#_version_and_release --> https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_release_tag > Group: System Environment/Base > BuildRoot: %{_tmppath}/%{name}-%{version}-build https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections Yes, there are still packages that haven't removed the "Group" tag, but typically if the guidelines say "SHOULD NOT" that is a strong recommendation not to override it without a compelling reason. If you need a custom buildroot, define it for your local build environment. > make There's few source files to compile, but as it's a review ticket, notice the section about "make": https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make $ rpm -E %make_build /usr/bin/make -O -j3 V=1 VERBOSE=1 > /usr/libexec/systemd-cron/mail_for_job > /usr/libexec/systemd-cron/boot_delay > /usr/libexec/systemd-cron/remove_stale_stamps > /usr/libexec/systemd-cron/crontab_setgid /usr/libexec/systemd-cron directory is "unowned" currently: https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2350109 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202350109%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
